Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inprod(a,b) #259

Merged
merged 8 commits into from
Dec 14, 2024
Merged

Update inprod(a,b) #259

merged 8 commits into from
Dec 14, 2024

Conversation

serenlee
Copy link
Contributor

I found that I have an error with current version inprod(a,b). * is not working for two vectors.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.37%. Comparing base (4f4772a) to head (6519ec4).
Report is 67 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   82.09%   73.37%   -8.73%     
==========================================
  Files          20       20              
  Lines        1748     1964     +216     
==========================================
+ Hits         1435     1441       +6     
- Misses        313      523     +210     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Dec 12, 2024

Pull Request Test Coverage Report for Build 12333227533

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 73.371%

Totals Coverage Status
Change from base Build 12333221996: 0.1%
Covered Lines: 1441
Relevant Lines: 1964

💛 - Coveralls

@sunxd3
Copy link
Member

sunxd3 commented Dec 12, 2024

thanks!

@sunxd3
Copy link
Member

sunxd3 commented Dec 12, 2024

@serenlee it looks like the formatting is failing but the CI is not working properly, it should be something like

return LinearAlgebra.dot(a, b)

also it would be great if you can add a simple test to file https://github.com/serenlee/JuliaBUGS.jl/blob/patch-1/test/bugs_primitives.jl

sorry for being pedantic, thanks a lot for this

@serenlee
Copy link
Contributor Author

serenlee commented Dec 13, 2024

Hi @sunxd3
Sorry for the late response. For unknown reasons, I didn’t get a notification.

I am new to Julia test and unable to access my machine today, - does the current test work? Also, your code
return LinearAlgebra.dot(a, b)
is the same as my current one. If you have any feedback, please let me know.

@sunxd3
Copy link
Member

sunxd3 commented Dec 14, 2024

@serenlee the formatter CI is a bit strange -- it usually show suggestions, but it's not doing that now. I took the liberty to do the formatting, hope it's not offensive.

@sunxd3
Copy link
Member

sunxd3 commented Dec 14, 2024

@serenlee thanks!

@sunxd3 sunxd3 merged commit 1b33f00 into TuringLang:master Dec 14, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants