-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update inprod(a,b) #259
Update inprod(a,b) #259
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #259 +/- ##
==========================================
- Coverage 82.09% 73.37% -8.73%
==========================================
Files 20 20
Lines 1748 1964 +216
==========================================
+ Hits 1435 1441 +6
- Misses 313 523 +210 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 12333227533Details
💛 - Coveralls |
thanks! |
@serenlee it looks like the formatting is failing but the CI is not working properly, it should be something like return LinearAlgebra.dot(a, b) also it would be great if you can add a simple test to file https://github.com/serenlee/JuliaBUGS.jl/blob/patch-1/test/bugs_primitives.jl sorry for being pedantic, thanks a lot for this |
Hi @sunxd3 I am new to Julia test and unable to access my machine today, - does the current test work? Also, your code |
@serenlee the formatter CI is a bit strange -- it usually show suggestions, but it's not doing that now. I took the liberty to do the formatting, hope it's not offensive. |
@serenlee thanks! |
I found that I have an error with current version inprod(a,b). * is not working for two vectors.