Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turing v0.36 and removal of Pathfinder code #579

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

mhauru
Copy link
Member

@mhauru mhauru commented Jan 16, 2025

This PR makes two unrelated changes:

  1. It upgrades Turing to v0.36, and correspondingly updates instructions for how to use the Gibbs sampler.
  2. It removes the code example for how to use Pathfinder, and thus the docs environment's dependency on Pathfinder.

These are in the same PR, because doing the first one made us realise that having Pathfinder as dependency is annoying: We couldn't upgrade Turing.jl to v0.36 because there was not yet a version of Pathfinder that included it in its compat, and we thus couldn't build docs for the latest version of our own package.

@mhauru mhauru requested a review from penelopeysm January 16, 2025 16:51
@penelopeysm
Copy link
Member

Oh no, something about the new Gibbs is failing 😓

@penelopeysm penelopeysm force-pushed the mhauru/0.36-gibbs branch 2 times, most recently from 56b03a4 to 40ed08a Compare January 17, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants