Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follower Service Always Reporting New Followers #87

Open
benrick opened this issue Oct 11, 2018 · 3 comments
Open

Follower Service Always Reporting New Followers #87

benrick opened this issue Oct 11, 2018 · 3 comments

Comments

@benrick
Copy link

benrick commented Oct 11, 2018

When I start a FollowerService and watch the OnNewFollowerDetected event, it always starts off by reporting 100 new followers. They're not new followers. I don't think it's setting its cache when the service starts. This means it always considers everyone to be "new" for the first trigger of the event.

This is the version of TwitchLib I am referencing.

    <PackageReference Include="TwitchLib" Version="3.0.1" />
@RRickkert
Copy link
Member

You have to manually call "UpdateLatestFollowersAsync(false);"
I thought I created a separate method though which called that internally. Something like "InitializeWithLatestFollowersAsync or something". Might be good to add that just for clarification.

@swiftyspiffy
Copy link
Member

@RRickkert how did you want to attack this? In the Start() method? I know the follower code extends the base monitor class, so that might be a bit tricky.

@RRickkert
Copy link
Member

The suggestion in the pull request might actually solve this problem for the FollowerService. Writing that, we might actually be able to implement the same kind of thing for the LiveStreamMonitorService. Because that one also has a "StartedAt" which we can use instead of the FollowedAt! So no need to put that in the Start() method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants