Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Default LastFollowerDate for Channels in FollowerService #88

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

benrick
Copy link

@benrick benrick commented Oct 11, 2018

Feel free to use this, toss it, or just reference what I'm talking about from it.

This is associated with #87

@RRickkert
Copy link
Member

A bit a late response, but I just checked it again and understand what your approach is there! Smart thinking! That would still have to be added to the 'SetChannelsById' method though, and would allow us to remove the 'bool callEvents = true' param in the UpdateLatestFollowersAsync method. I recently also noticed that I didn't add a clear method to basically say InitializeLatestFollowersAsync(), which was supposed to call UpdateLatestFollowersAsync(false), and so "initialize the latest followers", removing the need for your code.
But your way of working removes the need for that call! Nice thinking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants