nullable anotation Part 1 and new UndocumentedTags property
#246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocice` events and `MessageEmote.cs`
neon-sunset
approved these changes
Aug 7, 2023
neon-sunset
approved these changes
Aug 13, 2023
swiftyspiffy
approved these changes
Sep 16, 2023
| { | ||
| public sealed class OutboundChatMessageBuilder : IBuilder<OutboundChatMessage> | ||
| { | ||
| private string _channel; | ||
| private string _message; | ||
| private string _userName; |
There was a problem hiding this comment.
so i know the username here seemed kind of redundant, but i believe it was added because there were users of the library that had a single OutboundChatMessage event for multiple bot instances using multiple users, so they wanted to know which account/bot was sending the outgoing message.
Not apposed to removing though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.Client.Modelsproject (except:MessageEmote.cs, builders and all models based on USERNOTICE command)UndocumentedTagsproperty for most modelspart 2 will focus on
.Client,