Nullable anotation Part2 (+1 small "bux" fix)

[AoshiW]

1. Nullable annotation Part 2 for TwitchLib.Client
2. fixed bug with false positive OnFailureToReceiveJoinConfirmation when Capabilities.Tags is set to false

[swiftyspiffy]

lgtm, though this is going to be a breaking change for a lot of people right? given that if something is nullable it needs to be handled as such?

[Syzuna]

well the whole of v4 with the rewrite of the underlying communications package is full of breaking changes. so add it to the list :D

[AoshiW]

though this is going to be a breaking change for a lot of people right?

it depends, some people most people will get some warnings (or errors- depending on the project settings, the default is warnings) after upgrading to V4 but in the end it's not a bad thing. It's better if the IDE tells you "This may be null and you should check it." than to get a NullReferenceException.

given that if something is nullable it needs to be handled as such?

in most cases YES, (but you had to do the same check in V3, but there you didn't get a warning on null values)
but there will be cases when you know something is not null (for example you have 3 nullable properties and you know that if one of them is not null then the other 2 are not null either) and in such cases you can ignore it with !.