Updated ConnectionCredentials to use an anonymous user by default #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
your PR should target dev, not main |
|
My bad, I'll correct it in the morning |
|
you could also create a new constructor (or static method) with only |
If no username is provided to the ConnectionCredentials, a default username of `justinfan` right-padded with 4-5 random digits will be generated.
ChrisBlueStone
force-pushed
the
anonymous-user
branch
from
1c75fb9
to
ed0948f
Compare
AoshiW
reviewed
Nov 19, 2023
Co-authored-by: AoshiW <[email protected]>
ChrisBlueStone
force-pushed
the
anonymous-user
branch
from
de6f719
to
1bbfae9
Compare
|
looks good (but I still personally prefer the new constructor/static method) |
AoshiW
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no username is provided to the ConnectionCredentials, a default username of
justinfanright-padded with 4-5 random digits will be generated which will allow an anonymous connection to twitch.This follows the same logic used by tmi.js.