ConnectClientAsync - Fix "Cannot access a disposed object."

src/TwitchLib.Communication/Clients/ClientBase.cs

@@ -27,16 +27,16 @@
     private CancellationTokenSource _cancellationTokenSource;
 
     /// <summary>
     ///     This <see cref="_cancellationTokenSource"/> is used for <see cref="_networkServices.ListenTask"/>
     ///     whenever a call to <see cref="CancellationTokenSource.Cancel()"/> is made
     /// </summary>
     internal CancellationToken Token => _cancellationTokenSource.Token;
 
     internal static TimeSpan TimeOutEstablishConnection => TimeSpan.FromSeconds(15);
 
     protected readonly ILogger<ClientBase<T>>? Logger;
 
     protected abstract string Url { get; }
 
     /// <summary>
     ///     The underlying <typeparamref name="T"/> client.
@@ -237,16 +237,17 @@
                 return true;
             }
 
-            // Always create new client when opening new connection
-            Client = CreateClient();
-
             var first = true;
             Options.ReconnectionPolicy.Reset(isReconnect);
 
             while (!IsConnected &&
                    !Options.ReconnectionPolicy.AreAttemptsComplete())
             {
                 Logger?.TraceAction(GetType(), "try to connect");
+
+                // Always create new client when opening new connection
+                Client = CreateClient();
+
                 if (!first)
                 {
                     await Task.Delay(Options.ReconnectionPolicy.GetReconnectInterval(), CancellationToken.None);
@@ -284,7 +285,7 @@
     }
 
     /// <summary>
     ///     Stops <see cref="_networkServices.ListenTaskAsync"/>
     ///     by calling <see cref="CancellationTokenSource.Cancel()"/>
     ///     <br></br>
     ///     and enforces the <see cref="CloseClient"/>