Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed profile option PrivateKeyLocation #423

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

sredxny
Copy link
Contributor

@sredxny sredxny commented Nov 5, 2024

Description

rename from private_key_location to PrivateKeyLocation

Related Issue

https://tyktech.atlassian.net/browse/TT-13453

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
    • If new config option added, ensure that it can be set via ENV variable
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • When updating library version must provide reason/explanation for this update.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

@sredxny sredxny requested a review from kolavcic November 5, 2024 12:32
Copy link

sonarqubecloud bot commented Nov 5, 2024

@sredxny sredxny requested a review from mativm02 November 5, 2024 12:41
@sredxny sredxny enabled auto-merge (squash) November 5, 2024 12:42
Copy link

@kolavcic kolavcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sredxny sredxny merged commit 9ba9f0b into master Nov 5, 2024
10 checks passed
@sredxny sredxny deleted the rename-private_key_location branch November 5, 2024 12:42
@sredxny
Copy link
Contributor Author

sredxny commented Nov 5, 2024

/release to release-1.6

Copy link

tykbot bot commented Nov 5, 2024

Working on it! Note that it can take a few minutes.

tykbot bot pushed a commit that referenced this pull request Nov 5, 2024
Co-authored-by: sredny buitrago <[email protected]>
(cherry picked from commit 9ba9f0b)
Copy link

tykbot bot commented Nov 5, 2024

@sredxny Seems like there is conflict and it require manual merge.

sredxny added a commit that referenced this pull request Nov 5, 2024
Co-authored-by: sredny buitrago <[email protected]>
(cherry picked from commit 9ba9f0b)

Co-authored-by: Sredny M. <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants