Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[TT-12990] fix upstream endpoint RL not considering endpoint method (#…
…6651) ### **User description** <details open> <summary><a href="https://tyktech.atlassian.net/browse/TT-12990" title="TT-12990" target="_blank">TT-12990</a></summary> <br /> <table> <tr> <th>Summary</th> <td>API endpoint upstream rate limiting is not considering endpoint method</td> </tr> <tr> <th>Type</th> <td> <img alt="Bug" src="https://tyktech.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium" /> Bug </td> </tr> <tr> <th>Status</th> <td>In Dev</td> </tr> <tr> <th>Points</th> <td>N/A</td> </tr> <tr> <th>Labels</th> <td>-</td> </tr> </table> </details> <!-- do not remove this marker as it will break jira-lint's functionality. added_by_jira_lint --> --- <!-- Provide a general summary of your changes in the Title above --> ## Description This PR fixes a bug where upstream endpoint rate limit middleware doesn't consider endpoint method while generating redis key ## Related Issue https://tyktech.atlassian.net/browse/TT-12990 ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why ___ ### **PR Type** Bug fix, Tests ___ ### **Description** - Fixed a bug in the rate limit middleware where the HTTP method was not considered in the rate limit key generation, potentially causing incorrect rate limiting. - Enhanced the rate limit tests to include HTTP method consideration, ensuring that rate limits are correctly applied per method. - Refactored test functions to support method-specific rate limits and added a regression test to verify the fix. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>mw_api_rate_limit.go</strong><dd><code>Include HTTP method in rate limit key generation</code> </dd></summary> <hr> gateway/mw_api_rate_limit.go <li>Added <code>fmt</code> package import.<br> <li> Modified rate limit key generation to include HTTP method.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6651/files#diff-46326b04f936c839922e970db5c2924156cc797070948f3dc9c589d04661d6d2">+2/-1</a> </td> </tr> </table></td></tr><tr><td><strong>Tests</strong></td><td><table> <tr> <td> <details> <summary><strong>per_api_limit_test.go</strong><dd><code>Enhance rate limit tests to include HTTP method</code> </dd></summary> <hr> tests/rate/per_api_limit_test.go <li>Added HTTP method consideration in rate limit tests.<br> <li> Refactored test functions to support method-specific rate limits.<br> <li> Added regression test for per-method rate limiting.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6651/files#diff-81981a7ab606e7274913a4cf3030c12ef9d6856f2862420b6b069909f8175bd7">+61/-24</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information
- Loading branch information