-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-12417] Do not delete keys on synchronization #6642
base: master
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Let's make that PR title a 💯 shall we? 💪 Your PR title and story title look slightly different. Just checking in to know if it was intentional!
Check out this guide to learn more about PR best-practices. |
API Changes --- prev.txt 2024-10-23 15:24:33.760803273 +0000
+++ current.txt 2024-10-23 15:24:27.068799990 +0000
@@ -11734,11 +11734,15 @@
NewSyncForcer returns a new syncforcer with a connected redis with a key
prefix synchronizer-group- for group synchronization control.
+func (sf *SyncronizerForcer) GetIsFirstConnection() bool
+
func (sf *SyncronizerForcer) GroupLoginCallback(userKey string, groupID string) interface{}
GroupLoginCallback checks if the groupID key exists in the storage to turn
on/off ForceSync param. If the the key doesn't exists in the storage,
it creates it and set ForceSync to true
+func (sf *SyncronizerForcer) SetFirstConnection(isFirstConnection bool)
+
# Package: ./signature_validator
package signature_validator // import "github.com/TykTechnologies/tyk/signature_validator" |
Quality Gate failedFailed conditions |
TT-12417
Description
Avoiding key deletion when synchronizing. This will avoid having inconsistent key data between master and slave Redis.
Related Issue
https://tyktech.atlassian.net/browse/TT-12417?atlOrigin=eyJpIjoiYWNiZTdlNmYwODY5NDI1ZDkzYmQ1MWFlZjM5NGQ3ZTgiLCJwIjoiaiJ9
Motivation and Context
https://tyktech.atlassian.net/browse/TT-12417?atlOrigin=eyJpIjoiYWNiZTdlNmYwODY5NDI1ZDkzYmQ1MWFlZjM5NGQ3ZTgiLCJwIjoiaiJ9
How This Has Been Tested
Screenshots (if appropriate)
Types of changes
Checklist