Skip Twitch clip projections because they can't be rendered locally (#…

…1200)
Tyrrrz · Feb 13, 2024 · 7c04db4 · 7c04db4
1 parent 4588bd0
commit 7c04db4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/DiscordChatExporter.Cli.Tests/Specs/HtmlEmbedSpecs.cs b/DiscordChatExporter.Cli.Tests/Specs/HtmlEmbedSpecs.cs
@@ -150,7 +150,7 @@ public async Task I_can_export_a_channel_that_contains_a_message_with_a_Spotify_
         iframeUrl.Should().StartWith("https://open.spotify.com/embed/track/1LHZMWefF9502NPfArRfvP");
     }
 
-    [Fact]
+    [Fact(Skip = "Twitch does not allow embeds from inside local HTML files")]
     public async Task I_can_export_a_channel_that_contains_a_message_with_a_Twitch_clip_embed()
     {
         // https://github.com/Tyrrrz/DiscordChatExporter/issues/1196

diff --git a/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml b/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml
@@ -365,15 +365,6 @@
                                 </div>
                             </div>
                         }
-                        // Twitch embed
-                        else if (embed.TryGetTwitchClip() is { } twitchClipEmbed)
-                        {
-                            <div class="chatlog__embed">
-                                <div class="chatlog__embed-twitch-container">
-                                    <iframe class="chatlog__embed-twitch" src="@twitchClipEmbed.Url" width="400" height="225"></iframe>
-                                </div>
-                            </div>
-                        }
                         // YouTube embed
                         else if (embed.TryGetYouTubeVideo() is { } youTubeVideoEmbed)
                         {
@@ -457,7 +448,10 @@
                             </div>
                         }
                         // Generic video embed
-                        else if (embed.Kind == EmbedKind.Video && !string.IsNullOrWhiteSpace(embed.Url))
+                        else if (embed.Kind == EmbedKind.Video 
+                                 && !string.IsNullOrWhiteSpace(embed.Url)
+                                 // Twitch clips cannot be embedded in local HTML files
+                                 && embed.TryGetTwitchClip() is null)
                         {
                             var embedVideoUrl =
                                 embed.Video?.ProxyUrl ?? embed.Video?.Url ??