Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reusable workflow across molecule tests #116

Merged
merged 7 commits into from
Jun 5, 2024

Conversation

paddyroddy
Copy link
Member

In the process of fixing things around #115, we want to use different options in the composite action related to UCL-MIRSG/.github#121 & UCL-MIRSG/.github#122. This would mean we'd need to set extra options in the reusable workflow, which will get confusing. By removing the reusable workflow, this will simplify things greatly. This will lead to more verbose code, but better in the long-term.

@paddyroddy paddyroddy marked this pull request as ready for review June 5, 2024 12:22
@paddyroddy
Copy link
Member Author

@drmatthews and I worked on this one, so doesn't make sense that we review

Copy link
Member

@HChughtai HChughtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in #115 (comment) about pinning to major version of Ansible instead.

Additionally, could we specify the ansible_version in a repo or org wide variable? And then when we want to move to Ansible 10.x.x we'd only need to change in one place?

@paddyroddy
Copy link
Member Author

See comment in #115 (comment) about pinning to major version of Ansible instead.

Additionally, could we specify the ansible_version in a repo or org wide variable? And then when we want to move to Ansible 10.x.x we'd only need to change in one place?

Nice idea, incoming

@paddyroddy
Copy link
Member Author

I have updated the actions to use the major Ansible version. If actions pass, then assume this is good to go.

@paddyroddy paddyroddy requested a review from HChughtai June 5, 2024 14:27
@paddyroddy
Copy link
Member Author

@HChughtai the ones that are failing are due to the whole paths: mess and me updating manually pip install ansible==${{ vars.ANSIBLE_MAJOR_VERSION }}.* so they can be ignored

@paddyroddy paddyroddy merged commit 9ef026f into main Jun 5, 2024
21 of 25 checks passed
@paddyroddy paddyroddy deleted the remove-reusable-action branch June 5, 2024 14:36
drmatthews added a commit that referenced this pull request Jun 6, 2024
Follows on from #116, but made sense to be in a separate PR.

To be merged AFTER #116.

Fixes #111

---------

Co-authored-by: Daniel Matthews <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants