Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement components and front page #259

Merged
merged 25 commits into from
Mar 1, 2024
Merged

Implement components and front page #259

merged 25 commits into from
Mar 1, 2024

Conversation

No767
Copy link
Member

@No767 No767 commented Dec 31, 2023

Summary

This PR aims to address the need for migrating components to NextUI. The rationale behind it is simple: we are building a website, not a components library. In addition, the PR aims to implement the front landing page of the website.

The components implemented are detailed as such:

  • Global Navbar

This PR is incomplete but merging regardless in order to remove an dependency blocker

Types of changes

What types of changes does your code introduce to the UC Merced's ACM Chapter Website?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (Updates to README.md, the documentation, etc)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes. (if appropriate)
  • Lint, format, and unit test workflows pass with my new changes
  • This PR does not address a duplicate issue or PR

@No767 No767 self-assigned this Dec 31, 2023
@No767 No767 mentioned this pull request Dec 31, 2023
14 tasks
@No767 No767 marked this pull request as ready for review February 21, 2024 08:29
Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@No767 No767 merged commit cd8e567 into react-rewrite Mar 1, 2024
3 checks passed
@No767 No767 deleted the noelle/nextui branch March 1, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant