[0.2.dev7] MergedChoiceTable check for duplicate column names #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eh2406
reviewed
Dec 12, 2018
| # Check for duplicate column names | ||
| obs_cols = list(observations.columns) + list(observations.index.names) | ||
| alt_cols = list(alternatives.columns) + list(alternatives.index.names) | ||
| dupes = [c for c in obs_cols if c in alt_cols] |
There was a problem hiding this comment.
Why is this using lists (O(a*o)) instead of sets (O(min(a,o)))? like:
obs_cols = set(observations.columns) + set(observations.index.names)
alt_cols = set(alternatives.columns) + set(alternatives.index.names)
dupes = obs_cols & in alt_cols
There was a problem hiding this comment.
@Eh2406 Thanks, that's definitely better! Unfortunately i just merged this PR, but i'll update this in the next one
This was referenced Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to the MergedChoiceTable constructor to make sure there aren't any column names that overlap between the observations and alternatives tables.
It's ok for the
chosen_alternativescolumn of the observations table to have the same name as the index of the alternatives table, though.Discussion
This aligns ChoiceModels with the strategy for overlapping column names discussed in UrbanSim Templates issue #67.
Other changes
All the existing unit tests pass, and I wrote some new ones to test permutations of overlapping column names.
Versioning