Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDD-2371: Add support for manually setting min and max y-axis range #2050

Merged
merged 2 commits into from
Jan 17, 2025
Merged

CDD-2371: Add support for manually setting min and max y-axis range #2050

merged 2 commits into from
Jan 17, 2025

Conversation

phill-stanley
Copy link
Contributor

@phill-stanley phill-stanley commented Jan 6, 2025 •
edited
Loading

Description

This PR adds support for manually providing a minimum and maximum value to the simplified line chart's y-axis range

Fixes #CDD-2371

Type of change

Please select the options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tech debt item (this is focused solely on addressing any relevant technical debt)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests at the right levels to prove my change is effective
  • I have added screenshots or screen grabs where appropriate
  • I have added docstrings in the correct style (google)

@phill-stanley phill-stanley requested a review from a team as a code owner January 6, 2025 09:42
@phill-stanley
Copy link
Contributor Author

Screenshot 2025-01-06 at 09 44 44
Screenshot 2025-01-06 at 09 45 49

@phill-stanley phill-stanley force-pushed the task/cdd-2371-manual-y-axis-range-landing-page branch 4 times, most recently from 938b5de to 74c34fe Compare January 14, 2025 09:51
@phill-stanley phill-stanley force-pushed the task/cdd-2371-manual-y-axis-range-landing-page branch 3 times, most recently from 1200ba3 to f605d47 Compare January 17, 2025 15:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
75.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@phill-stanley phill-stanley merged commit 2088894 into main Jan 17, 2025
13 of 14 checks passed
@phill-stanley phill-stanley deleted the task/cdd-2371-manual-y-axis-range-landing-page branch January 17, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A-Ashiq A-Ashiq A-Ashiq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phill-stanley @A-Ashiq