Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDD-2432 Implement Middleware - Adds permission models #2195

Merged
merged 14 commits into from
Feb 27, 2025
Merged

CDD-2432 Implement Middleware - Adds permission models #2195

merged 14 commits into from
Feb 27, 2025

Conversation

mxrman
Copy link
Collaborator

@mxrman mxrman commented Feb 17, 2025 •
edited
Loading

Description

This PR includes the following:
Adds The following models to the data app.

  • api_groups
Screenshot 2025-02-12 at 15 41 49
  • api_groups_permissions
Screenshot 2025-02-12 at 15 42 56
  • api_permissions
Screenshot 2025-02-12 at 15 43 52

Also adds some organising of the existing api models: Moves the APITimeSeriesFactory model into a api_models package (including tests).

Fixes #CDD-2432

Type of change

Please select the options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tech debt item (this is focused solely on addressing any relevant technical debt)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests at the right levels to prove my change is effective
  • I have added screenshots or screen grabs where appropriate
  • I have added docstrings in the correct style (google)

@mxrman mxrman requested a review from a team as a code owner February 17, 2025 10:39
@mxrman mxrman force-pushed the task/auth-middleware_CDD-2432-rbac-models branch from 0be0e67 to 3ce8ea7 Compare February 17, 2025 10:42
@mxrman mxrman mentioned this pull request Feb 17, 2025
Closed
9 tasks
@mxrman mxrman force-pushed the task/auth-middleware_CDD-2432-rbac-models branch 5 times, most recently from fd61a82 to ffcf144 Compare February 17, 2025 12:04
@mxrman
CDD-2432 Implement Middleware - Adds permission models
4b26f84 
CDD-2432 linting

CDD-2432 add missing permissions exception tests

CDD-2432 add missing permissions exception tests

CDD-2432 migration file name change

CDD-2432 remove comment

CDD-2432 docs

CDD-2432 docs2

CDD-2432 admin
@mxrman mxrman force-pushed the task/auth-middleware_CDD-2432-rbac-models branch from e7511c4 to 4b26f84 Compare February 17, 2025 12:14
@mxrman
CDD-2432 changes after review #3
0ea66b5 
CDD-2432 changes after review #3 (tests)

CDD-2432 changes after review #3 (tests2)
@mxrman mxrman force-pushed the task/auth-middleware_CDD-2432-rbac-models branch from 1a72d4d to 0ea66b5 Compare February 18, 2025 15:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mxrman mxrman merged commit c481ab5 into main Feb 27, 2025
14 checks passed
@mxrman mxrman deleted the task/auth-middleware_CDD-2432-rbac-models branch February 27, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A-Ashiq A-Ashiq A-Ashiq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxrman @A-Ashiq