Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/cdd 2285 add new subtitle and about label #2204

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Task/cdd 2285 add new subtitle and about label #2204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e0ae4c6
feature/CDD-2285: Add new subtitle to chart and ChartWithHeadlineAndT…
luketowell Feb 20, 2025
2b66c6a
feature/CDD-2285: update for linting
luketowell Feb 20, 2025
06bbaf4
feature/CDD-2285: update to add label
luketowell Feb 20, 2025
6f088e3
task/CDD-2285: linting
luketowell Feb 20, 2025
8efed6c
task/CDD-2285: fix typo
luketowell Feb 20, 2025
28e5258
task/CDD-2285: add a default value of for empty sub-titles
luketowell Feb 20, 2025
7259ac2
task/CDD-2285: update body to subtitle and new About field
luketowell Feb 21, 2025
aa4f866
task/CDD-2285: update body to subtitle
luketowell Feb 21, 2025
27c9f8f
CDD-2285: update migrations
luketowell Feb 24, 2025
d578cad
CDD-2285: Update migration file names to be more descriptive
luketowell Feb 25, 2025
0e08d6b
Merge branch 'main' into task/CDD-2285-add-new-subtitle-and-about-label
luketowell Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions cms/dynamic_content/cards.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,12 @@ class Meta:

class ChartWithHeadlineAndTrendCard(blocks.StructBlock):
title = blocks.TextBlock(required=True, help_text=help_texts.TITLE_FIELD)
body = blocks.TextBlock(required=False, help_text=help_texts.OPTIONAL_BODY_FIELD)
body = blocks.TextBlock(
required=False, help_text=help_texts.OPTIONAL_BODY_FIELD, label="Subtitle"
)
about = blocks.TextBlock(
required=False, help_text=help_texts.OPTIONAL_CHART_ABOUT_FIELD
)
tag_manager_event_id = blocks.CharBlock(
required=False,
help_text=help_texts.TAG_MANAGER_EVENT_ID_FIELD,
Expand Down Expand Up @@ -187,7 +192,12 @@ class Meta:

class ChartCard(blocks.StructBlock):
title = blocks.TextBlock(required=True, help_text=help_texts.TITLE_FIELD)
body = blocks.TextBlock(required=False, help_text=help_texts.OPTIONAL_BODY_FIELD)
body = blocks.TextBlock(
required=False, help_text=help_texts.OPTIONAL_BODY_FIELD, label="Subtitle"
)
about = blocks.TextBlock(
required=False, default="", help_text=help_texts.OPTIONAL_CHART_ABOUT_FIELD
)
tag_manager_event_id = blocks.CharBlock(
required=False,
help_text=help_texts.TAG_MANAGER_EVENT_ID_FIELD,
Expand Down
6 changes: 5 additions & 1 deletion cms/dynamic_content/help_texts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,12 @@
The sub title to display for this component.
"""

OPTIONAL_CHART_ABOUT_FIELD: str = """
An optional body of text to accompany this block. This text will be displayed in the about content of the chart.
"""

OPTIONAL_BODY_FIELD: str = """
An optional body of text to accompany this block.
An optional body of text to accompany this block. This text will be displayed below the chart title.
"""

REQUIRED_BODY_FIELD: str = """
Expand Down
Loading