ASL-4149 - lint fixes

UKHomeOffice · Nov 18, 2022 · 304d711 · 304d711
1 parent 1172c06
commit 304d711
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 10 deletions.
diff --git a/controllers/convert.js b/controllers/convert.js
@@ -26,4 +26,3 @@ module.exports = router.post('/',
       next(err);
     });
   });
-
diff --git a/lib/missing-data.js b/lib/missing-data.js
@@ -1,14 +1,14 @@
 'use strict';
 
 const _ = require('lodash');
-const mustacheRe = /{{\s*[\w\.]+\s*}}/g;
+const mustacheRe = /{{\s*[\w.]+\s*}}/g;
 
 // Compares the data to the template placeholders and
 // returns a comma separated string of missing items from the data
 module.exports = (template, data) => {
   const keys = _.keys(data);
   const list = _.map(template.match(mustacheRe), x => {
-    return x.match(/[\w\.]+/)[0];
+    return x.match(/[\w.]+/)[0];
   });
   return _.difference(list, keys);
 };
diff --git a/models/converter.js b/models/converter.js
@@ -8,14 +8,14 @@ module.exports = class PDFConverterModel {
 
     const opts = {
       args: [
-          '--no-sandbox',
-          '--disable-setuid-sandbox',
-          '--disable-dev-shm-usage',
-          '--ignore-certificate-errors'
+        '--no-sandbox',
+        '--disable-setuid-sandbox',
+        '--disable-dev-shm-usage',
+        '--ignore-certificate-errors'
       ]
     };
 
-    options = Object.assign({
+    const optionsWithFormatAndWaitUntil = Object.assign({
       format: 'A4',
       waitUntil: 'load'
     }, options);
@@ -24,8 +24,8 @@ module.exports = class PDFConverterModel {
       .then(browser => {
         return browser.newPage()
           .then(page => {
-            return page.setContent(html, { waitUntil: options.waitUntil })
-              .then(() => page.pdf(options))
+            return page.setContent(html, { waitUntil: optionsWithFormatAndWaitUntil.waitUntil })
+              .then(() => page.pdf(optionsWithFormatAndWaitUntil))
               .then(data => Buffer.from(data, 'base64'));
           })
           .then(data => {

diff --git a/test/integration/index.js b/test/integration/index.js
@@ -1,5 +1,7 @@
 'use strict';
 
+const sinon = require('sinon');
+const assert = require('assert');
 const supertest = require('supertest');
 const puppeteer = require('puppeteer');
 const mustache = require('mustache');

diff --git a/test/unit/lib/missing-data.js b/test/unit/lib/missing-data.js
@@ -1,5 +1,6 @@
 'use strict';
 
+const assert = require('assert');
 const path = require('path');
 const fs = require('fs');
 const missingData = require('../../../lib/missing-data');

diff --git a/test/unit/middleware/validate.js b/test/unit/middleware/validate.js
@@ -1,5 +1,7 @@
 'use strict';
 
+const sinon = require('sinon');
+const assert = require('assert');
 const validate = require('../../../middleware/validate');
 const ValidationError = require('../../../lib/validation-error');
Original file line number	Diff line number	Diff line change
Expand Up		@@ -26,4 +26,3 @@ module.exports = router.post('/',
		next(err);
		});
		});