Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rod 81 82 #38

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Rod 81 82 #38

wants to merge 4 commits into from

Conversation

vinodhasamiyappanHO
Copy link
Contributor

What?

  • ROD-82 - Create a VISA TYPE page
  • ROD-81 - Create a FURTHER LEAVE TO REMAIN page

Why?

  • Creating new pages for VISA TYPE and FURTHER LEAVE TO REMAIN type page in ROD main flow

How?

  • Added necessary step configuration and field specific variables.
  • Added required field validation for all pages
  • Added summary page entry in summary-data-sections.js and routing logic from Point A(/application) to point B (/reference-number)
  • Added all forks condition to get the get the required pages in the main flow

Testing?

Screenshots (optional)

Anything Else? (optional)

Check list

  • I have reviewed my own pull request for linting issues (e.g. adding new lines)
  • I have written tests (if relevant)
  • I have created a JIRA number for my branch
  • I have created a JIRA number for my commit
  • I have followed the chris beams method for my commit https://cbea.ms/git-commit/
    here is an example commit
  • Ensure drone builds are green especially tests
  • I will squash the commits before merging

…ROD form and added /application page label to test flow easily and all forks conditions
Copy link
Contributor

@vivekkumar-ho vivekkumar-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vinodhasamiyappanHO vinodhasamiyappanHO marked this pull request as ready for review October 23, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants