Skip to content

Commit

Permalink
HOFF-1059: Fix failing functional test in Github workflowflow
Browse files Browse the repository at this point in the history
- rollback ubuntu version from latest to 22.04 (the latest update is the cause of the failing workflow)
- update node version to version 20
- update actions/checkout to version 4
- update actions/setup-node to version 4
- rename pr template so it will be generated automatically
  • Loading branch information
Rhodine-orleans-lindsay committed Jan 9, 2025
1 parent 977f7bf commit 7fdf1c2
Show file tree
Hide file tree
Showing 6 changed files with 551 additions and 34 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/automate-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ on:
- completed
jobs:
auto-publish:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
if: startsWith(github.ref, 'refs/heads/master')
steps:
- uses: actions/checkout@v2.2.0
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: actions/setup-node@v1
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 20
registry-url: https://registry.npmjs.org/
- name: 'Get Previous tag'
id: previoustag
Expand Down
32 changes: 16 additions & 16 deletions .github/workflows/automate-tag.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ name: Automate_Tag
on: [push]
jobs:
test:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
strategy:
matrix:
node-version: [14.x]
node-version: [20.x]
redis-version: [4, 5, 6]
steps:
- uses: actions/checkout@v2.2.0
- uses: actions/setup-node@v1
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Start Redis
Expand All @@ -25,16 +25,16 @@ jobs:

auto-tag-patch:
needs: test
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
if: |
startsWith(github.ref, 'refs/heads/master') &&
!contains(github.event.head_commit.message, '[MAJOR]') &&
!contains(github.event.head_commit.message, '[MINOR]')
steps:
- uses: actions/checkout@v2.2.0
- uses: actions/setup-node@v1
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 20
registry-url: https://registry.npmjs.org/
- run: |
git config --local user.email "$(git log --format='%ae' HEAD^!)"
Expand All @@ -43,16 +43,16 @@ jobs:
auto-tag-minor:
needs: test
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
if: |
startsWith(github.ref, 'refs/heads/master') &&
!contains(github.event.head_commit.message, '[MAJOR]') &&
contains(github.event.head_commit.message, '[MINOR]')
steps:
- uses: actions/checkout@v2.2.0
- uses: actions/setup-node@v1
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 20
registry-url: https://registry.npmjs.org/
- run: |
git config --local user.email "$(git log --format='%ae' HEAD^!)"
Expand All @@ -61,16 +61,16 @@ jobs:
auto-tag-major:
needs: test
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
if: |
startsWith(github.ref, 'refs/heads/master') &&
contains(github.event.head_commit.message, '[MAJOR]') &&
!contains(github.event.head_commit.message, '[MINOR]')
steps:
- uses: actions/checkout@v2.2.0
- uses: actions/setup-node@v1
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 20
registry-url: https://registry.npmjs.org/
- run: |
git config --local user.email "$(git log --format='%ae' HEAD^!)"
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1733,3 +1733,4 @@ Copy `assets/javascript/vendor` into your javascript directory (ie `hmpo/vendor`
- Navigation.html contains a journeyHeaderURL, which is set in the controller.
- getJourneyHeaderURL within the controller translates an empty baseURL to '/'.
- The above helps fix broken journey header URLs in the GRO and UKVIC services which both have a baseURL's set to '/'.
test automate tag
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"unit": "LOG_LEVEL=error nyc _mocha \"test/**/*.spec.js\" \"sandbox/test/**/*.spec.js\"",
"unit:nocov": "LOG_LEVEL=error mocha \"test/**/*.spec.js\" \"sandbox/test/**/*.spec.js\"",
"test:lint": "eslint . --config ./node_modules/eslint-config-hof/default.js",
"test:functional": "funkie mocha ./test/functional-tests --timeout 20000 --exit",
"test:functional": "funkie mocha ./test/functional-tests --timeout 10000 --exit",
"test:client": "karma start test/frontend/toolkit/karma.conf.js",
"test:cookie-banner": "jest test/frontend/jest",
"test:acceptance": "TAGS=\"${TAGS:=@feature}\" yarn run test:cucumber",
Expand Down
File renamed without changes.
Loading

0 comments on commit 7fdf1c2

Please sign in to comment.