HOFF 593 HTTP Error 404 (Not Found) Error Page #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, much improved commit. I would just change the wording of the subject of the commit to |
- Replaced html content in 404.html page to display 404 error message - added 404 text in errors.json file - added translations in not-found.js to allow text be render on 404.html page
TemitopeAyokuHO
force-pushed
the
HOFF-593-HTTP-Error-404-Not-Found
branch
from
f6c57f2 to
1a7f411
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
HOFF-593 Adding content to 404 error page
Why
To follow the GDS standard for 404 error page
How
Test
Tested locally