Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOFF-699: Update accessibility statement classes #457

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mislam987
Copy link
Contributor

@mislam987 mislam987 commented Jun 17, 2024

What?

Update the accessibility statement page to include the missing style classes - HOFF-699

Why?

To ensure the elements on the page align with GDS standards

How?

Add the govuk-list--bullet class name to the <ul> tags in frontend/template-partials/views/accessibility.html

Testing?

Tested on other services

Screenshots (optional)

After applying the change and removing the overriding accessibility.html page on the LMR form:

image

Anything Else? (optional)

Check list

  • I have reviewed my own pull request for linting issues (e.g. adding new lines)
  • I have written tests (if relevant) - not applicable
  • I have created a JIRA number for my branch
  • I have created a JIRA number for my commit
  • I have followed the chris beams method for my commit https://cbea.ms/git-commit/
    here is an example commit
  • Ensure drone builds are green especially tests
  • I will squash the commits before merging

@mislam987 mislam987 force-pushed the HOFF-699-update-classes branch from 89067dd to 16b3aed Compare June 18, 2024 12:13
@mislam987 mislam987 requested a review from sulthan-ahmed June 18, 2024 12:25
package.json Outdated
@@ -1,7 +1,7 @@
{
"name": "hof",
"description": "A bootstrap for HOF projects",
"version": "20.5.4",
"version": "20.5.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to add this for patch changes, once you merge, it'll automatically do it in our setup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted back to the previous version.

- modify style classes for ul tags to align with GDS standards
@mislam987 mislam987 force-pushed the HOFF-699-update-classes branch from 16b3aed to 49ae7d8 Compare June 18, 2024 12:58
Copy link
Contributor

@sulthan-ahmed sulthan-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work man

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants