updates: remove amazon_ses patches and run updates #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build outputComposer Validate `success`PHP Lint `success`Docker Build `success`Environment Setup `success`Site Install `success`PHP Code Sniffer `success`Software VersionsPHP 8.2.27 (cli) (built: Dec 19 2024 07:26:44) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.27, Copyright (c) Zend Technologies
with Zend OPcache v8.2.27, Copyright (c), by Zend Technologies
with Xdebug v3.4.0, Copyright (c) 2002-2024, by Derick Rethans
Composer version 2.8.5 2025-01-21 15:23:40
Drupal LogsPHP LogsPusher: @lazysoundsystem, Action: `pull_request`, Workflow: `Run tests``; |
|
In theory you are correct. The module owner decided to implement the fix in a different way, so the error should not happen if we remove the patch. |
|
@lazysoundsystem @cafuego The patch from owner is buggy: |
|
Thanks @orakili ! I'm changing the patch for all the repos. |
Coverage Report
|
|
Merged the change into the upstream merge requests, thanks @orakili |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: OPS-11278
I replaced PATCHES/3416368-error-not-caught-queue.patch with PATCHES/amazon_ses-cron-queue-3417090-5.patch - @cafuego does that seem right? I'll try the same on the other repos, but we have time to find another fix before deployment if necessary.