Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CD-519 Remove missing UNOCHA logo from base theme via patch #683

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

left23
Copy link
Contributor

@left23 left23 commented Nov 20, 2023

chore: create patch that removes logo from common_design base theme, add to patches file

See CD-519 for screenshots and details.

Once this patch is applied, the declaration in the common_design base theme rule that sets the UNOCHA logo as a background background: linear-gradient(transparent, transparent), url(../../../img/logos/ocha-logo-blue.svg) center no-repeat; is no longer present, which means we no longer have a reference to a missing image.

This will be tested after its deployed. If it has a positive impact on SEO, we will implement this properly in the base theme as described on CD-519

Copy link

github-actions bot commented Nov 20, 2023

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.12 (cli) (built: Oct 26 2023 17:33:49) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.12, Copyright (c) Zend Technologies with Zend OPcache v8.2.12, Copyright (c), by Zend Technologies with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.6.5 2023-10-06 10:11:52
Drupal Logs

Pusher: @orakili, Action: pull_request, Workflow: Run tests

@left23 left23 requested a review from orakili November 20, 2023 14:41
Copy link
Collaborator

@orakili orakili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch applies cleanly. Thanks.

Copy link

Coverage Report

Totals Coverage
Statements: 11.71% ( 1089 / 9297 )
Methods: 11.57% ( 82 / 709 )
Lines: 11.73% ( 1007 / 8588 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants