Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add mail modules #697

Closed
wants to merge 5 commits into from
Closed

chore: add mail modules #697

wants to merge 5 commits into from

Conversation

lazysoundsystem
Copy link
Contributor

Refs: OPS-9523

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024 •
edited
Loading

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.14 (cli) (built: Dec 21 2023 20:19:50) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.14, Copyright (c) Zend Technologies with Zend OPcache v8.2.14, Copyright (c), by Zend Technologies with Xdebug v3.3.0, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.6.6 2023-12-08 18:32:26
Drupal Logs

Pusher: @lazysoundsystem, Action: pull_request, Workflow: Run tests

@github-actions GitHub Actions
Copy link

Coverage Report

Totals Coverage
Statements: 9.28% ( 1089 / 11730 )
Methods: 12.04% ( 82 / 681 )
Lines: 9.11% ( 1007 / 11049 )

@lazysoundsystem
Copy link
Contributor Author

Note - adjusted the threshold for test coverage from 10% to 8% so that the checks can pass.

@cafuego cafuego requested a review from orakili January 24, 2024 01:56
@cafuego
Copy link
Contributor

cafuego commented Jan 24, 2024

RW doesn't use the Drupal mail() function to send its subscription mails, does it?

@lazysoundsystem lazysoundsystem mentioned this pull request Jan 25, 2024
Merged
cafuego
cafuego requested changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@cafuego cafuego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to need to drop in some extra changes.

@orakili
Copy link
Collaborator

orakili commented Apr 15, 2024

Closing in favor of #773.

@orakili orakili closed this Apr 15, 2024
@lazysoundsystem lazysoundsystem deleted the OPS-9523-add-mail-modules branch April 15, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cafuego cafuego cafuego requested changes

@orakili orakili Awaiting requested review from orakili

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lazysoundsystem @cafuego @orakili