Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rw 821 #698

Merged
merged 10 commits into from
Jan 11, 2024
Merged

Rw 821 #698

merged 10 commits into from
Jan 11, 2024

Conversation

attiks
Copy link
Contributor

@attiks attiks commented Jan 10, 2024

No description provided.

@attiks attiks requested a review from orakili January 10, 2024 08:59
@attiks
Copy link
Contributor Author

attiks commented Jan 10, 2024

@orakili this is failing on install, but no idea why, I thought I saw it mentioned somewhere but couldn't find it

Copy link

github-actions bot commented Jan 11, 2024

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.14 (cli) (built: Dec 21 2023 20:19:50) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.14, Copyright (c) Zend Technologies with Zend OPcache v8.2.14, Copyright (c), by Zend Technologies with Xdebug v3.3.0, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.6.6 2023-12-08 18:32:26
Drupal Logs

Pusher: @orakili, Action: pull_request, Workflow: Run tests

Copy link
Collaborator

@orakili orakili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well.

I added a commit to fix a "Warning: Attempt to read property "entity" on null" for entities without a country like remote jobs or online training.

Copy link

Coverage Report

Totals Coverage
Statements: 9.14% ( 1089 / 11920 )
Methods: 11.57% ( 82 / 709 )
Lines: 8.98% ( 1007 / 11211 )

@attiks attiks merged commit f7aa701 into develop Jan 11, 2024
1 of 2 checks passed
@orakili orakili deleted the RW-821 branch February 27, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants