Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RW-841 Update base theme to v9.3 #708

Merged
merged 1 commit into from
Jan 15, 2024
Merged

RW-841 Update base theme to v9.3 #708

merged 1 commit into from
Jan 15, 2024

Conversation

left23
Copy link
Contributor

@left23 left23 commented Jan 15, 2024

This specifically avails of a recent update to the base theme to load fonts in a non-blocking manner. This was included in base theme release v9.2.3
See UN-OCHA/common_design#448 for Font testing steps

There has since been another update for v9.3 which uses the SDC and rearranges the directory structure in the base theme.
https://github.com/UN-OCHA/common_design/releases/tag/v9.3.0

We shouldn't need to do anything to react to the v9.3 update since we do not reference any component's location using the directories, but instead use library extends when interacting with base theme components.

Refs: RW-841

@left23 left23 changed the title RW-841 Update base theme to v3 RW-841 Update base theme to v9.3 Jan 15, 2024
@left23 left23 self-assigned this Jan 15, 2024
@left23 left23 requested a review from orakili January 15, 2024 09:40
Copy link

Coverage Report

Totals Coverage
Statements: 9.28% ( 1089 / 11730 )
Methods: 12.04% ( 82 / 681 )
Lines: 9.11% ( 1007 / 11049 )

Copy link

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.14 (cli) (built: Dec 21 2023 20:19:50) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.14, Copyright (c) Zend Technologies with Zend OPcache v8.2.14, Copyright (c), by Zend Technologies with Xdebug v3.3.0, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.6.6 2023-12-08 18:32:26
Drupal Logs

Pusher: @left23, Action: pull_request, Workflow: Run tests

Copy link
Collaborator

@orakili orakili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@orakili orakili merged commit 2fad406 into develop Jan 15, 2024
1 of 2 checks passed
@orakili orakili deleted the RW-841 branch February 27, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants