Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added /pastexams #129

Merged
merged 11 commits into from
Jul 13, 2023
Merged

Added /pastexams #129

merged 11 commits into from
Jul 13, 2023

Conversation

49Indium
Copy link
Member

@49Indium 49Indium commented Jun 26, 2023

Added /pastexams, a command that can get past exams for subjects, filtering by year and semester. Heavily inspired by @bradleysigma's unimplemented version. This also gets us slightly closer to closing #1.

Also, during this I discovered that the UQ library has an API. This could potentially be used for more commands.

@49Indium 49Indium changed the title Added \pastexams Added /pastexams Jun 26, 2023
Copy link
Member

@andrewj-brown andrewj-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with changes.

uqcsbot/past_exams.py Outdated Show resolved Hide resolved
uqcsbot/utils/uq_course_utils.py Outdated Show resolved Hide resolved
uqcsbot/past_exams.py Show resolved Hide resolved
Copy link
Member

@andrewj-brown andrewj-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought I will block this on the UQ SSO note, but everything else, up to you.

@49Indium 49Indium added the enhancement update an existing command or cog for some new functionality label Jul 2, 2023
Copy link
Member

@andrewj-brown andrewj-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and merging

@andrewj-brown andrewj-brown merged commit 689af81 into main Jul 13, 2023
3 checks passed
@49Indium 49Indium deleted the pastexams branch July 17, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement update an existing command or cog for some new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants