LaTeX: Added error checking for the equation #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewj-brown
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
LGTM, although this is a small pr, in a fairly disused cog, with future changes planned. It might be prudent to wrap this up with the rest of the LaTeX changes needed to resolve #139.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fix to catch when the equations cannot be rendered. Does slow down
/latexslightly, as image is requested once by the bot and once by discord.This partially solves #139, though we might need to consider running LaTeX on the bot's side in future (codecogs is a pretty average emulation of TeX IMO). I'd like to discuss the security and costs of this.