Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whatsdue: Added Sorting #142

Merged
merged 9 commits into from
Oct 27, 2023
Merged

Whatsdue: Added Sorting #142

merged 9 commits into from
Oct 27, 2023

Conversation

49Indium
Copy link
Member

As per here, added sorting for whatsdue. Can now sort by due date, weight and course name.

Also neatened up uq_course_utils by adding an Assessment dataclass.

@49Indium 49Indium mentioned this pull request Aug 3, 2023
3 tasks
@49Indium 49Indium linked an issue Aug 3, 2023 that may be closed by this pull request
3 tasks
@49Indium
Copy link
Member Author

49Indium commented Aug 3, 2023

Please don't merge yet, as I'll add the other features wanted by #145 (hopefully this week).

Copy link
Member

@andrewj-brown andrewj-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (almost). Two very minor things.

Happy to be wontfix'ed on both, just making sure they're considered.

uqcsbot/utils/uq_course_utils.py Outdated Show resolved Hide resolved
uqcsbot/utils/uq_course_utils.py Outdated Show resolved Hide resolved
Copy link
Member

@andrewj-brown andrewj-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and merging

@andrewj-brown andrewj-brown merged commit eaadaf8 into main Oct 27, 2023
3 checks passed
@49Indium 49Indium deleted the whatsdue branch November 30, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whatsdue enhancements
2 participants