Fix Types for bot.py #206
Draft
Fix Types for bot.py #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49Indium
added
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apscheduler has prerelease versions with typing. This PR prepares
bot.pyto pass pyright typing checks once apscheduler v4 is released for production. There are some additional breaking changes when moving to v4, which are fixed by this PR.This PR should also fix the types surrounding
aiohttp.Note to test this PR before the production release of apscheduler, edit the
pyproject.tomlto use the dependencyAPScheduler = {version = "^4.0.0a1", allow-prereleases = true}.To ensure that this is not closed before updating the version of apscheduler:
pyproject.tomlto require apscheduler version^4.0.0