update based on code review

US-CBP · Jul 9, 2024 · 60d6384 · 60d6384
1 parent 7cff80d
commit 60d6384
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/packages/web-components/src/components/cbp-badge/cbp-badge.scss b/packages/web-components/src/components/cbp-badge/cbp-badge.scss
@@ -4,17 +4,12 @@
  * @Prop --cbp-badge-color-dark: var(--cbp-color-text-darkest);
  * @Prop --cbp-badge-color-background: var(--cbp-color-info-base);
  * @Prop --cbp-badge-color-background-dark: var( --cbp-color-interactive-secondary-lighter); 
- * @Prop --cbp-badge-color-background-danger: var(--cbp-color-danger-dark);
- * @Prop --cbp-badge-color-background-danger-dark: var(--cbp-color-danger-light);
  */
 :root{
   --cbp-badge-color: var(--cbp-color-text-lightest);
   --cbp-badge-color-dark: var(--cbp-color-text-darkest);
   --cbp-badge-color-background: var(--cbp-color-info-base);
   --cbp-badge-color-background-dark: var( --cbp-color-interactive-secondary-lighter); 
-
-  --cbp-badge-color-background-danger: var(--cbp-color-danger-dark);
-  --cbp-badge-color-background-danger-dark: var(--cbp-color-danger-light);
 }
 
 [data-cbp-theme=light] cbp-badge[context*=dark]:not([context=light-always]),
@@ -39,6 +34,7 @@ cbp-badge {
   line-height: var(--cbp-space-6x);
 
   &[color=danger] {
-    background-color: var(--cbp-badge-color-background-danger);
+    --cbp-badge-color-background: var(--cbp-color-danger-dark);
+    --cbp-badge-color-background-dark: var(--cbp-color-danger-light);
   }
 }
diff --git a/packages/web-components/src/components/cbp-tag/cbp-tag.scss b/packages/web-components/src/components/cbp-tag/cbp-tag.scss
@@ -50,7 +50,7 @@ cbp-tag {
 
   &[color=danger] {
     --cbp-tag-color: var(--cbp-color-text-lightest);
-    --cbp-tag-color-dark: var(-cbp-color-text-darkest);
+    --cbp-tag-color-dark: var(--cbp-color-text-darkest);
 
     --cbp-tag-color-background: var(--cbp-color-danger-base);
     --cbp-tag-color-background-dark: var(--cbp-color-danger-light);