Reduced string operations when searching for JSON node names #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilianC
force-pushed
the
json-load-string-comparison-optimization
branch
from
122179a
to
7d1d4c5
Compare
|
Pardon, silly extra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first
strlen()call required that thesearchNameis iterated entirely, even if the followingstrncmp()would be able to early-out when the first characters don't match.The pre-calculated length is only used to constrain the string comparison, but
strcmp()will handle the ends of both strings just fine, and early-out as soon as possible.The second call to
strlen()was to ensure thatsearchNamedidn't just match a prefix of a longercurrentName.strcmp()also accounts for this, but will early-out if the string is a single character longer, without having to walk the entirecurrentName.