Feature/move tests to jest #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correct the README, bump for travis builds as well but only LTS (skip 9)
node built-in modules not needed for d3-request dependency
removes the need for saucelabs
3.13.1 does not have pre-compiled binaries for node 8.x or 10.x per https://github.com/sass/node-sass/releases/tag/v4.0.0 4.0.0 is backwards compatible with 3.13.1
|
I noticed node-sass is a bit out of date, I'll update it to save Travis time (via compilation of C). |
|
Closing this request. The changes were merged into the updated react update tests PR in order to combine them with our newest changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commits from #131 and #133 but switches the tests from karma to jest's jsdom to avoid the need for saucelabs
also runs linting after the unit tests, and adds a "build" script
potential watchout point: updates React from 14 to 16
🤞 for a good Travis build