Math refactor #283
Merged
Math refactor #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, just wondering where those functions come from ? most of the new functions look unused, do we want to commit only the ones we need ? or is that part of a copy/pasted lib ? |
crypto-vincent
previously approved these changes
Jul 29, 2023
Closed
|
Ideally we would replace the old maths with the new one, but let's start with new code instead |
acamill
previously approved these changes
Jul 31, 2023
crypto-vincent
approved these changes
Aug 7, 2023
acamill
approved these changes
Aug 7, 2023
cnek
added a commit
that referenced
this pull request
Sep 4, 2023
* [Update] Updating tests to credix 0.7.5 update (#279) * branches update * [Router] Make all mint/redeem IXs permissioned (except router) (#281) * Math refactor (#283) * math improvement * added back metadata.address * mod fix * update solana and uxd-cpi version --------- Co-authored-by: Vincent Brunet <[email protected]> * [Credix] Bug Fix: Under-requested rebalancing (#289) * [Router] Enforce redeem outflow limitations (#288) * updated readme * minor * correct-merging-mistake --------- Co-authored-by: uxd-vincent <[email protected]> Co-authored-by: Vincent Brunet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking down #280
the renaming part of existing ixs,