Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Bulk Image Convertor function #225

Closed
wants to merge 1 commit into from
Closed

Added a Bulk Image Convertor function #225

wants to merge 1 commit into from

Conversation

Anushlinux
Copy link

I have created a convertor.py file in which i have added the conversion logic which converts any png image to jpeg or jpg or tiff and vice-versa

Pls review the code and let me know

@Udayraj123
Copy link
Owner

Hey @Anushlinux, thanks for raising the PR for image conversion. Just one problem, you'd need to port this code onto the dev branch first. And in terms of code structure, you can follow what's added in the scripts/local folder instead of src since src will contain some code that is used directly when running OMRChecker.

Please check this comment and update your PR on top of the dev branch if possible. #213 (comment)

After that can you also check the scripts/hooks/convert_images_hook.py file in dev and see if we can import your function in that hook to have the same functionality?

@Anushlinux Anushlinux closed this by deleting the head repository Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants