Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add provider spec for disabling default GKE provider behavior #91

Merged
merged 10 commits into from
Feb 27, 2024

Conversation

waveywaves
Copy link
Member

@waveywaves waveywaves commented Feb 26, 2024

fixes #85

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 114 lines in your changes are missing coverage. Please review.

Project coverage is 5.42%. Comparing base (c2da179) to head (c7ba666).
Report is 145 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #91       +/-   ##
==========================================
- Coverage   19.58%   5.42%   -14.16%     
==========================================
  Files           4       9        +5     
  Lines         388     884      +496     
==========================================
- Hits           76      48       -28     
- Misses        308     836      +528     
+ Partials        4       0        -4     
Files Coverage Δ
src/controllers/uffizzicluster/workload.go 0.00% <0.00%> (ø)
...ollers/uffizzicluster/uffizzicluster_controller.go 0.00% <0.00%> (ø)

Copy link

github-actions bot commented Feb 26, 2024

Uffizzi Cluster pr-91 was deleted.

@waveywaves waveywaves merged commit d5e15a8 into main Feb 27, 2024
5 of 7 checks passed
@waveywaves waveywaves deleted the fix/2/85 branch March 12, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor cluster operator to remove hard-coded Google Cloud values
1 participant