[430] Refactor cluster creation

UffizziCloud · Jun 20, 2023 · 89a6685 · 89a6685
1 parent a07b15e
commit 89a6685
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/core/app/services/uffizzi_core/cluster_service.rb b/core/app/services/uffizzi_core/cluster_service.rb
@@ -21,7 +21,6 @@ def deploy_cluster(cluster)
         return cluster.fail!
       end
 
-
       UffizziCore::Cluster::ManageDeployingJob.perform_in(5.seconds, cluster.id)
     end
 

diff --git a/core/test/controllers/uffizzi_core/api/cli/v1/projects/clusters_controller_test.rb b/core/test/controllers/uffizzi_core/api/cli/v1/projects/clusters_controller_test.rb
@@ -35,9 +35,11 @@ class UffizziCore::Api::Cli::V1::Projects::ClustersControllerTest < ActionContro
       },
     }
 
-    data = json_fixture('files/controller/cluster_not_ready.json')
-    stubbed_create_cluster_request = stub_create_cluster_request(data)
+    cluster_creation_data = json_fixture('files/controller/cluster_not_ready.json')
     stubbed_create_namespace_request = stub_create_namespace_request
+    stubbed_create_cluster_request = stub_create_cluster_request(cluster_creation_data)
+    cluster_show_data = json_fixture('files/controller/cluster_ready.json')
+    stubbed_cluster_request = stub_get_cluster_request(cluster_show_data)
 
     differences = {
       -> { UffizziCore::Cluster.count } => 1,
@@ -50,6 +52,7 @@ class UffizziCore::Api::Cli::V1::Projects::ClustersControllerTest < ActionContro
     assert_response(:success)
     assert_requested(stubbed_create_cluster_request)
     assert_requested(stubbed_create_namespace_request)
+    assert_requested(stubbed_cluster_request)
   end
 
   test '#create when enabled cluster with the same name exists' do
@@ -85,9 +88,11 @@ class UffizziCore::Api::Cli::V1::Projects::ClustersControllerTest < ActionContro
       },
     }
 
-    data = json_fixture('files/controller/cluster_not_ready.json')
-    stubbed_create_cluster_request = stub_create_cluster_request(data)
+    cluster_creation_data = json_fixture('files/controller/cluster_not_ready.json')
     stubbed_create_namespace_request = stub_create_namespace_request
+    stubbed_create_cluster_request = stub_create_cluster_request(cluster_creation_data)
+    cluster_show_data = json_fixture('files/controller/cluster_ready.json')
+    stubbed_cluster_request = stub_get_cluster_request(cluster_show_data)
 
     differences = {
       -> { UffizziCore::Cluster.count } => 1,
@@ -100,12 +105,11 @@ class UffizziCore::Api::Cli::V1::Projects::ClustersControllerTest < ActionContro
     assert_response(:success)
     assert_requested(stubbed_create_cluster_request)
     assert_requested(stubbed_create_namespace_request)
+    assert_requested(stubbed_cluster_request)
   end
 
   test '#show' do
     cluster = create(:cluster, project: @project, deployed_by: @user, name: 'test')
-    data = json_fixture('files/controller/cluster_ready.json')
-    stubbed_cluster_request = stub_get_cluster_request(data)
 
     params = {
       project_slug: @project.slug,
@@ -115,7 +119,6 @@ class UffizziCore::Api::Cli::V1::Projects::ClustersControllerTest < ActionContro
     get :show, params: params, format: :json
 
     assert_response(:success)
-    assert_requested(stubbed_cluster_request)
   end
 
   test '#destroy' do

diff --git a/core/test/dummy/config/settings.yml b/core/test/dummy/config/settings.yml
@@ -66,3 +66,5 @@ continuous_preview:
 deployment:
   subdomain:
     length_limit: 63
+vcluster:
+  max_creation_retry_count: 5
-Original file line number
+Diff line change
@@ Expand Up / @@ -21,7 +21,6 @@ def deploy_cluster(cluster) @@
             return cluster.fail!
           end
           UffizziCore::Cluster::ManageDeployingJob.perform_in(5.seconds, cluster.id)
         end
@@ Expand Down @@