Add restart support for docker-compose #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct_describe_backend Feature/85 project describe backend
…re/85_project_describe_backend Revert "Feature/85 project describe backend"
This reverts commit e23297c7d4b27d7b6f59bb055cb938fc3bba6cdf. (cherry picked from commit b93108249bc51e44e475dcaca29d369ce2a23822)
waveywaves
force-pushed
the
feature/support-restart
branch
5 times, most recently
from
dcd42ad to
8056eac
Compare
Convert docker-compose restart options to Kubernetes restartPolicy docker-compose docs: https://docs.docker.com/compose/compose-file/#restart kubernetes docs: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#restart-policy
waveywaves
force-pushed
the
feature/support-restart
branch
from
8056eac to
637c323
Compare
|
Tagging @moklidia for review of this PR |
moklidia
reviewed
Jun 15, 2022
| when 'no', 'always', 'on-failure' | ||
| restart_policy | ||
| when 'unless-stopped' | ||
| raise UffizziCore::ComposeFile::ParseError, I18n.t('compose.invalid_restart_policy') |
There was a problem hiding this comment.
Let's add a default case
|
|
||
| hello-world: | ||
| image: nginx:latest | ||
| restart: always |
There was a problem hiding this comment.
Let's add a test to check that the option is parsed correctly
the38th
reviewed
Jun 15, 2022
| @@ -152,6 +152,7 @@ | |||
| t.string "command" | |||
| t.string "service_name" | |||
| t.jsonb "healthcheck" | |||
| t.jsonb "restart" | |||
There was a problem hiding this comment.
why restart is jsonb? It's looks like a string
zipofar
reviewed
Jun 15, 2022
| class UffizziCore::ComposeFile::Parsers::Services::RestartParserService | ||
| class << self | ||
| def parse(restart_data) | ||
| return nil if restart_data.nil? |
There was a problem hiding this comment.
We can do return if restart_data.nil? without explicitly return nil
zipofar
reviewed
Jun 15, 2022
|
|
||
| private | ||
|
|
||
| def parse_restart(restart_data) |
There was a problem hiding this comment.
Maybe it would be better to put this code in the method def parse? I mean, this code looks simple and maybe it doesn't make sense to split it into two methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert docker-compose restart options to Kubernetes restartPolicy
docker-compose docs:
https://docs.docker.com/compose/compose-file/#restart
kubernetes docs:
https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#restart-policy
fixes #140