Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: allow newer .net versions STUD-71044 #451

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

alexandru-petre
Copy link
Collaborator

Set the RollForward=Major property in the project file.

https://uipath.atlassian.net/browse/STUD-71044

Copy link

sonarcloud bot commented Nov 11, 2024

@sorinconstantin
Copy link
Collaborator

My understanding is that RollForward helps the application to determine which installed version of, in this case framework, to use in case the one requested is not installed on the machine it runs on.
So, in the case described by the issue, how does it work? 🤔

@@ -2,6 +2,7 @@
<Import Project="..\Python.build.props" />
<PropertyGroup>
<TargetFrameworks>net461;net6.0-windows;net6.0</TargetFrameworks>
<RollForward>Major</RollForward>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<RollForward>Major</RollForward>
<RollForward>LatestMajor</RollForward>

aren't we susceptible to this ?

Minor version roll-forward has one side-effect that may affect end users. Consider the following scenario:

  1. The application specifies that 5.0 is required.
  2. When run, version 5.0.* isn't installed, however, 5.1.0 is. Version 5.1.0 will be used.
  3. Later, the user installs 5.0.3 and runs the application again, 5.0.3 will now be used.

It's possible that 5.0.3 and 5.1.0 behave differently, particularly for scenarios like serializing binary data.

and couldn't we avoid it by always using the latest? (Of course, a similar change in behavior can occur when rolling forward as well, but at least rolling forward is intended, while backwards is not)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants