Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CURA-10722] backend plugins are always (potential) additional setting definition providers #16305

Merged
merged 3 commits into from
Aug 3, 2023
Merged

[CURA-10722] backend plugins are always (potential) additional setting definition providers #16305

merged 3 commits into from
Aug 3, 2023

Commits on Jul 28, 2023

  1. Ease of use; each backend-plugin can now provide additional settings. 

    Any overriding cals that does so, should just add 'self.definition_file_paths' to load their additional settings. However, at the moment of this commit, you should still suppy setting_definitions_appender in the list of __init__.register for the plugin.

part of CURA-10722
    @rburema
    rburema committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    7c810ee View commit details
    Browse the repository at this point in the history

  2. Backend-plugins don't have to register separately for extra setting-d… 

    …efs.

Also they now have their own appender-type (previously it was _always_ 'PLUGIN', now the other plugins are 'EXTRA').

part of CURA-10722
    @rburema
    rburema committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    4c82098 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Use "PLUGIN" as default appender_type

    @casperlamboo
    casperlamboo authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    4f2b038 View commit details
    Browse the repository at this point in the history