Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CURA-11815] Fix 'early' auto-slice. #19755

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

rburema
Copy link
Member

@rburema rburema commented Oct 15, 2024

This could cause slicing to hang forever until settings where changed. So stop too-early slicing, but keep a memo of whether we've already been requested to slice in the initialization interval, so auto-slice doesn't fail either.

This could cause slicing to hang forever until settings where changed. So stop too-early slicing, but keep a memo of wether we've already been requested to slice in the initialization interval, so auto-slice doesn't fail either.

CURA-11815
Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense !

@HellAholic HellAholic merged commit 1e60a15 into 5.9 Oct 18, 2024
9 checks passed
@HellAholic HellAholic deleted the CURA-11815_fix_early_autoslice branch October 18, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants