Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve Japanese translation for 5.9 #19817

Merged
merged 2 commits into from
Oct 28, 2024
Merged

improve Japanese translation for 5.9 #19817

merged 2 commits into from
Oct 28, 2024

Conversation

h1data
Copy link
Contributor

@h1data h1data commented Oct 27, 2024

Description

Improving Japanese localization for 5.9
Resolves: #19438

Type of change

  • Translations

How Has This Been Tested?

  • Compiled *.mo file by gettext and checked the appearance of the built application.

Test Configuration:

  • Operating System: Windows 11

Checklist:

@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Oct 27, 2024
@h1data
Copy link
Contributor Author

h1data commented Oct 27, 2024

@wawanbreton Here is the Japanese translation updated for 5.9.

Our changes in #19473 were reverted in 546df30,
so I updated the changes again with additional corrections since #19473.
Lokalize folks might have only applied template *.pot files except revised *.po files.
Could you inform them about the translation changes?

@wawanbreton
Copy link
Contributor

Thanks ! I'll take a look at the PR quickly.

Could you inform them about the translation changes?

Not really, I am not in direct contact with the translators. However I am the one running the procedure to send the labels to be translated. This procedure is still being debugged, so maybe there is still something wrong with it. Or maybe I just got confused because your PR arrived at the same time as the translations and I did something wrong.

Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as far as I can read Japanese, which is very close to 0 😆
Just one question about keyboard shortcuts.

resources/i18n/ja_JP/cura.po Show resolved Hide resolved
@wawanbreton wawanbreton merged commit a2598ea into Ultimaker:5.9 Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants