Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Eazao printer settings to allow material selection. #19818

Closed
wants to merge 19 commits into from

Conversation

Eazao
Copy link
Contributor

@Eazao Eazao commented Oct 27, 2024

Some time ago, we submitted the settings for M500, M600, M700, Potter and Zero printers.

#16294

We downloaded the latest Cura 5.9.0_beta.1 version and found that we could not select materials.

According to the suggestions, we changed the retract settings to "true" and changed "has material" to "true".

Ultimaker/fdm_materials#308

We would like to update these settings for the M500, M600, M700, Potter and Zero printers.

TheSin- and others added 19 commits August 10, 2024 12:53
- Add UI to set `machine_start_gcode_first` so that no gcode is adding infront of the start_gcode.
- Add float input box to set `machine_extruder_change_duration` which added proper extruder change times to the estimated print time.
- Add textbox to set `machine_extruder_prestart_code` to add gcodes that will run pre extruder change, things like heat up so we are at change before with pick up the next extruder.
value overrides formula and default value sets the initial value.
if value is overridden, the formula cannot update it based on the infill sparse density changes
the fdmprinter definition formula calculates as 8 for 10% infill
According to the suggestions, the retract setting was changed to "true" and the "has material" was changed to "true".
According to the suggestions, the retract setting was changed to "true" and the "has material" was changed to "true".
According to the suggestions, the retract setting was changed to "true" and the "has material" was changed to "true".
According to the suggestions, the retract setting was changed to "true" and the "has material" was changed to "true".
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

Comment on lines +61 to 62
"retraction_enable": { "value": true },
"retraction_extrusion_window": { "value": 10 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding retraction_enable with the same value (value: True) as defined in parent definition: fdmprinter

Suggested change
"retraction_enable": { "value": true },
"retraction_extrusion_window": { "value": 10 },
"retraction_extrusion_window": { "value": 10 },

Comment on lines +61 to 62
"retraction_enable": { "value": true },
"retraction_extrusion_window": { "value": 10 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding retraction_enable with the same value (value: True) as defined in parent definition: fdmprinter

Suggested change
"retraction_enable": { "value": true },
"retraction_extrusion_window": { "value": 10 },
"retraction_extrusion_window": { "value": 10 },

Comment on lines +61 to 62
"retraction_enable": { "value": true },
"retraction_extrusion_window": { "value": 10 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding retraction_enable with the same value (value: True) as defined in parent definition: fdmprinter

Suggested change
"retraction_enable": { "value": true },
"retraction_extrusion_window": { "value": 10 },
"retraction_extrusion_window": { "value": 10 },

Comment on lines +61 to 62
"retraction_enable": { "value": true },
"retraction_extrusion_window": { "value": 10 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding retraction_enable with the same value (value: True) as defined in parent definition: fdmprinter

Suggested change
"retraction_enable": { "value": true },
"retraction_extrusion_window": { "value": 10 },
"retraction_extrusion_window": { "value": 10 },

Comment on lines 61 to 62
"retraction_combing_max_distance": { "value": 0 },
"retraction_count_max": { "value": 100 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding retraction_combing_max_distance with the same value (value: 0) as defined in parent definition: fdmprinter

Suggested change
"retraction_combing_max_distance": { "value": 0 },
"retraction_count_max": { "value": 100 },
"retraction_count_max": { "value": 100 },

Comment on lines +63 to 64
"retraction_enable": { "value": true },
"retraction_extrusion_window": { "value": 10 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding retraction_enable with the same value (value: True) as defined in parent definition: fdmprinter

Suggested change
"retraction_enable": { "value": true },
"retraction_extrusion_window": { "value": 10 },
"retraction_extrusion_window": { "value": 10 },

@HellAholic
Copy link
Contributor

@Eazao The PR you made was not correct. You selected the incorrect base for the PR causing conflicts, so I'm closing this PR, I've added the changes that would enable material usage to #19819

Keep in mind, I have no way of testing these changes on your printer and validating the results with a print using the proposed material in Ultimaker/fdm_materials#308.
Therefore the assumption is that you have tested and validated these yourself.

@HellAholic HellAholic closed this Oct 27, 2024
@Eazao
Copy link
Contributor Author

Eazao commented Oct 28, 2024

@Eazao The PR you made was not correct. You selected the incorrect base for the PR causing conflicts, so I'm closing this PR, I've added the changes that would enable material usage to #19819

Keep in mind, I have no way of testing these changes on your printer and validating the results with a print using the proposed material in Ultimaker/fdm_materials#308. Therefore the assumption is that you have tested and validated these yourself.

Hi HellAholic,

Thanks for your help. We will test and verify it ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants