Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix required plugins #891

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Fix required plugins #891

merged 3 commits into from
Aug 15, 2023

Conversation

nallath
Copy link
Member

@nallath nallath commented Jul 28, 2023

This will actually re-enable plugins that are marked as required. It should never have bene possible to disable required plugins in the first place.

Goes with Ultimaker/Cura#16304

This also makes the logging better as it logs all the plugins that could not
be loaded
@github-actions
Copy link

github-actions bot commented Jul 28, 2023

Unit Test Results

2 404 tests  ±0   2 389 ✔️ ±0   25s ⏱️ -2s
       1 suites ±0        15 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit fef9bb5. ± Comparison against base commit 012a475.

♻️ This comment has been updated with latest results.

@saumyaj3 saumyaj3 merged commit 4abe8e4 into main Aug 15, 2023
5 checks passed
@saumyaj3 saumyaj3 deleted the fix_required_plugins branch August 15, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants