Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mac builds #936

Merged
merged 8 commits into from
Feb 6, 2024
Merged

Fix mac builds #936

merged 8 commits into from
Feb 6, 2024

Conversation

casperlamboo
Copy link
Contributor

@casperlamboo casperlamboo commented Jan 31, 2024 •
edited
Loading

See Cura PR: Ultimaker/Cura#18188

CURA-11483

@casperlamboo casperlamboo marked this pull request as ready for review February 5, 2024 10:35
wawanbreton
wawanbreton approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, no risk or regression in this part

@wawanbreton wawanbreton merged commit 95a1377 into main Feb 6, 2024
7 of 9 checks passed
@wawanbreton wawanbreton deleted the CURA-11483 branch February 6, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawanbreton wawanbreton wawanbreton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casperlamboo @wawanbreton