-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clearing memory stack #950
base: main
Are you sure you want to change the base?
Conversation
CURA-11658
This update refines the cleanup process across different parts of the application. Node reset functionality has been introduced which thoroughly cleans up the memory. Clear functions within SettingOverrideDecorator, SceneNodeDecorator, ConvexHullDecorator and others are improved to completely cleanse after usage. This approach ensures a more efficient use and management of memory resources. CURA-11658
only the set of operations within the specified range are deleted. This fine-tuned approach minimizes needless memory cleanups and enhances overall memory management. CURA-11658
CURA-11658
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same remark as for the other PR, I'm afraid of crashes, and I think methods naming is inconsistent.
The "clear" method has been renamed to "clearDecoratorData" to improve clarity on its function in several classes. This change affects the SettingOverrideDecorator, SceneNodeDecorator, ConvexHullDecorator, and SceneNode classes. CURA-11658
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same remark as for Ultimaker/Cura#18883, still some reserve about this but I let you move on.
CURA-11658