Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURA-12138 export for support option #970

Merged
merged 5 commits into from
Oct 7, 2024

Conversation

wawanbreton
Copy link
Contributor

@wawanbreton wawanbreton commented Sep 27, 2024

CURA-12138

  • Allow saving a project file without setting the name as the project name
  • Allow giving extra arguments to a file writer
  • Allow FileLogger to flush the current file and returns the list of used files paths

ℹ️ This does include a change in the signature of WorkspaceWriter.write which is a base method overridden by plugins. The change is only adding **kwargs to the signature, and I did check that a plugin not updating his signature would still properly get the function call. This should then be natively retro-compatible.

UM/FileHandler/WriteFileJob.py Outdated Show resolved Hide resolved
@HellAholic HellAholic merged commit 1b54414 into main Oct 7, 2024
7 checks passed
@HellAholic HellAholic deleted the CURA-12138-Export_for_support_option branch October 7, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants