[CURA-12190] Expand the circumstances under which we expect the C++ object to be gone. #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…one. This was uncovered after caching, but might've existed before; that extra update function that's now within the try could _also_ call the emitters, causing the same problem for which the existing try-catches where made. CURA-12190
wawanbreton
approved these changes
Oct 16, 2024
I think that's mostly a result from coupling a garbage collected language so tightly with a self-managed one, and then try to have objects that correspond to each other on both sides of that barrier managed by yet another system that has been known to have some bugs -- and then I come along and try to do caching 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was uncovered after caching, but might've existed before; that extra update function that's now within the try could also call the emitters, causing the same problem for which the existing try-catches where made.